Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Question config form with better loading #42806

Draft
wants to merge 1 commit into
base: better-loading
Choose a base branch
from

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 16, 2024

Important

For those employed by Metabase: if you are merging into master, please add either a backport or a no-backport label
to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this
PR?

in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not
apply to you, and the label will be taken care of by your reviewer.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

Copy link
Contributor Author

rafpaf commented May 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@rafpaf rafpaf mentioned this pull request May 16, 2024
1 task
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 16, 2024
@rafpaf rafpaf changed the title Squash Question config form with better loading May 16, 2024
@rafpaf rafpaf changed the title Question config form with better loading [wip] Question config form with better loading May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant