Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Metabot Cool Again #42797

Merged
merged 2 commits into from
May 20, 2024
Merged

Make Metabot Cool Again #42797

merged 2 commits into from
May 20, 2024
+109 −7

Conversation

iethree
Copy link
Contributor

@iethree iethree commented May 16, 2024

Description

Like it says in the title 😎

@iethree iethree requested review from a team and kdoh May 16, 2024 20:52
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

Codenotify: Notifying subscribers in CODENOTIFY files for diff 02e42f3...90a10b9.

Notify File(s)
@ranquild frontend/src/metabase/home/components/HomeGreeting/HomeGreeting.styled.tsx
frontend/src/metabase/home/components/HomeGreeting/HomeGreeting.tsx
frontend/src/metabase/home/components/HomeGreeting/HomeGreeting.unit.spec.tsx

@iethree iethree added the no-backport Do not backport this PR to any branch label May 16, 2024
@replay-io replay.io
Copy link

replay-io bot commented May 16, 2024 •
edited

Status Complete ↗︎
Commit 90a10b9
Results
⚠️ 3 Flaky
✅ 2507 Passed

@iethree iethree added backport Automatically create PR on current release branch on merge and removed no-backport Do not backport this PR to any branch labels May 17, 2024
@iethree iethree requested a review from perivamsi May 20, 2024 13:15
rafpaf
rafpaf approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rafpaf rafpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@iethree iethree merged commit 5e562cd into master May 20, 2024
131 checks passed
@iethree iethree deleted the cool-metabot branch May 20, 2024 13:32
@github-actions GitHub Actions
Copy link

@iethree Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@iethree iethree added this to the 0.50 milestone May 20, 2024
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@iethree
Make Metabot Cool Again (#42797)
79f45f4 
* Make Metabot Cool Again

* update tests
@metabase-bot metabase-bot bot mentioned this pull request May 20, 2024
Merged
metabase-bot bot added a commit that referenced this pull request May 20, 2024
@metabase-bot @iethree
Make Metabot Cool Again (#42797) (#42886)
193988c 
* Make Metabot Cool Again

* update tests

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafpaf rafpaf rafpaf approved these changes

@kdoh kdoh Awaiting requested review from kdoh

@perivamsi perivamsi Awaiting requested review from perivamsi

Assignees

@iethree iethree

Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iethree @rafpaf