Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding font in SDK #42341

Closed
WiNloSt opened this issue May 7, 2024 · 0 comments · Fixed by #42855
Closed

Allow overriding font in SDK #42341

WiNloSt opened this issue May 7, 2024 · 0 comments · Fixed by #42855
Assignees
@deniskaber
Labels
Embedding/SDK Embedding SDK for React .Team/Embedding Type:New Feature

Comments

@WiNloSt
Copy link
Member

WiNloSt commented May 7, 2024 •
edited

Currently, the visualization is using its own font from getFont selector.

metabase/frontend/src/metabase/visualizations/components/Visualization/Visualization.jsx

Line 68 in 1060973

fontFamily: getFont(state),

This breaks the customizing font from the SDK if we set it differently from the instance font.

p.s. there are other places that might need the same remedy as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniskaber deniskaber

Labels
Embedding/SDK Embedding SDK for React .Team/Embedding Type:New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow charts font override in SDK metabase/metabase
3 participants
@albertoperdomo @WiNloSt @deniskaber