Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom user interface colors does not get applied on SDK #42705

Closed
Tracked by #42694
heypoom opened this issue May 15, 2024 · 0 comments · Fixed by #42834
Closed
Tracked by #42694

Custom user interface colors does not get applied on SDK #42705

heypoom opened this issue May 15, 2024 · 0 comments · Fixed by #42834
Assignees
@heypoom

Comments

@heypoom
Copy link
Contributor

heypoom commented May 15, 2024 •
edited

Custom user interface colors does not get applied to the SDK. In addition, the SDK always throws a runtime error regarding MetabaseSettings.get("application-colors") being undefined at runtime, therefore the updateColors method in whitelabel.js is returning an error in the SDK. The value is not properly loaded.

See reproduction on #42663 (comment)
@heypoom heypoom assigned heypoom and unassigned heypoom May 15, 2024
@heypoom heypoom mentioned this issue May 16, 2024
Merged
1 task
@heypoom heypoom changed the title SDK throws an error on updateColors method due to application-colors being undefined Custom user interface colors does not get applied on SDK and throws a runtime error on updateColors method May 16, 2024
@heypoom heypoom self-assigned this May 17, 2024
This was referenced May 17, 2024
Merged
Open
@heypoom heypoom changed the title Custom user interface colors does not get applied on SDK and throws a runtime error on updateColors method Custom user interface colors does not get applied on SDK May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heypoom heypoom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk): apply user interface color overrides to the sdk metabase/metabase
1 participant
@heypoom