Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Data Management from Shopping List #3603

Conversation

michael-genson
Copy link
Collaborator

@michael-genson michael-genson commented May 15, 2024

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

This PR enables managing data from a shopping list. Namely:

  1. Foods and units can be created from the shopping list (similar to how they can be created from recipes)
  2. Food labels can be changed if the shopping list item uses a different label than the food

This also fixes a visual bug when creating new foods/units on recipes by force-closing the dropdown.

Creating foods from the shopping list (with fixed visual bug):
2024-05-15_11h27_50

Assigning label to food (note that other instances of "apple" are not updated because those items are already set to produce):
2024-05-15_11h28_28

(not pictured: the food "apple" is now re-labeled as "Juice")

Which issue(s) this PR fixes:

(REQUIRED)

Closes #3602

Testing

(fill-in or delete this section)

Manually

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few linter issues on this one @michael-genson

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm effectively happy to approve this, bar the linting issues previously mentioned and ..

The "Copy to Food" functionality. I like it, but I wonder it it's going to not be clear to a user what it's actually doing? Particularly for say the 2nd and 3rd user of a system, not the "power user".. Thoughts? Wondering if there's an alternate wording, maybe something like "Permanently add Label to Food" (..but not exactly that)

@michael-genson
Copy link
Collaborator Author

Yeah I couldn't come up with anything concise enough other than "Copy to Food". Some others:

  • Assign to Food
  • Apply Label to Food
  • Update Food Data
  • Change Food Label
  • Change Food Data Label
  • Move Food to Label

I was avoiding "permanently" because it seems like a bulky word here, but that could work too. Also maybe adding a tooltip can work?

@Kuchenpirat
Copy link
Collaborator

Kuchenpirat commented May 22, 2024

I would suggest going for something shorter like Label Food or Add Label

I think you kinda don't need to reference Food since this is the toggled option. But a tooltip might be a nice middleground, but are not that practical on mobile.

@michael-genson
Copy link
Collaborator Author

michael-genson commented May 22, 2024

Maybe "Set Label" or "Apply Label"? Or "Save Label"? I agree with dropping Food. It's more than "Add" because a Food might already have a Label, just a different one.

@michael-genson
Copy link
Collaborator Author

Updated to "Save Label":
image

@boc-the-git boc-the-git enabled auto-merge (squash) May 22, 2024 21:53
@boc-the-git boc-the-git merged commit ca26639 into mealie-recipes:mealie-next May 22, 2024
10 checks passed
@michael-genson michael-genson deleted the feat/data-management-from-shopping-list branch May 22, 2024 22:10
boc-the-git added a commit to boc-the-git/mealie that referenced this pull request May 23, 2024
Co-authored-by: boc-the-git <3479092+boc-the-git@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants