-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Search and List Creator #9279
base: master
Are you sure you want to change the base?
Bulk Search and List Creator #9279
Conversation
This reverts commit 3355bb4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice great work @benbdeitch ! Did a first pass 👍
Main notes:
- I think you forgot to add the
BulkSearch.vue
file! 😁 - Can you format the vue files? I'm not sure why it's not causing eslint troubles 🤔 But it's a little hard to read. I'd recommend installing the Vue offical VS code extension ( https://marketplace.visualstudio.com/items?itemName=Vue.volar ) and then for each file, run auto form
shift-alt-f
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
b48ed3d
to
dee9e8c
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9279 +/- ##
==========================================
+ Coverage 15.89% 16.12% +0.23%
==========================================
Files 90 92 +2
Lines 4732 4768 +36
Branches 824 828 +4
==========================================
+ Hits 752 769 +17
- Misses 3468 3481 +13
- Partials 512 518 +6 ☔ View full report in Codecov by Sentry. |
Closes #7653
With this PR, the long-requested Bulk Search feature is finally functional. It enables users to extract books and titles from sections of text, and search the Open LIbrary database for each pair, at the click of a button. ChatGPT-based extraction is functional, but requires the user to supply their own key for that purpose.
Technical
The majority of the changes involve the addition of a new Vue component. Rather than conveying information between individual components by event watchers, information is instead conveyed through a state defined in
/openlibrary/components/BulkSearch/utils/classes.js
.Currently, the 'create a new list' function is not supported, but I intend to resolve that within the next few days.
Unfortunately, there were some limitations with how the table displays. Horizontal scrolling will likely be needed to navigate it, in cases where there are a large amount of works retrieved by a given search. This will likely be addressed in a future pull request.
Testing
Simply use the component, which is located at
localhost:8080/bulk/search
.Screenshot
Stakeholders
@cdrini