Separate template for search facets from work_search.html #9276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #7271
Moves search facets sidebar into its own template. The new
work_search_facets
template supports asynchronous loading, and will displayLoading...
indicators whenfacet_counts
isNone
.Technical
Testing
As of now, there is no way to trigger
async_load
mode via the UI. However, you can make the following change towork_search.html
to view the loading indicators:https://github.com/internetarchive/openlibrary/pull/9276/files#r1602125790
Screenshot
Facet sidebar when
facet_counts
isNone
.Stakeholders