-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update elmax_api to v0.0.5 #117693
Merged
bdraco
merged 2 commits into
home-assistant:dev
from
albertogeniola:elmax/update_dependency_library
May 20, 2024
Merged
Update elmax_api to v0.0.5 #117693
bdraco
merged 2 commits into
home-assistant:dev
from
albertogeniola:elmax/update_dependency_library
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
dependency
integration: elmax
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
May 18, 2024
This was referenced May 18, 2024
joostlek
approved these changes
May 18, 2024
albertogeniola
force-pushed
the
elmax/update_dependency_library
branch
from
May 18, 2024 14:44
f5defff
to
b269b2a
Compare
joostlek
approved these changes
May 18, 2024
It doesn't looks like there are any bugfixes in this lib bump that would require a backport. Does this need to be backported? |
No, it doesn't. To fix the bug I am referring to, we also need to apply another (separate) PR (#117689) |
bdraco
approved these changes
May 20, 2024
I agree. Let's follow the standard release model. Thank you!
…On Mon, May 20, 2024, 07:18 J. Nick Koston ***@***.***> wrote:
If #117689 <#117689> gets
tagged for backport, we can come back and tag this one. #117689
<#117689> is probably too
large to backport though and beta on the 29th so it might be better to wait
for it to go though the normal release process.
—
Reply to this email directly, view it on GitHub
<#117693 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDO7C7Q6VXLOM62GFVO5KLZDGBRHAVCNFSM6AAAAABH5QMBV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGY4DMMBZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
bajansen
pushed a commit
to bajansen/homeassistant
that referenced
this pull request
May 20, 2024
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
dependency
integration: elmax
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Upgrade dependency elmax_api to 0.0.5. Needed for #117689.
Changes introduced to 0.0.5:
https://github.com/albertogeniola/elmax-api/releases/tag/v0.0.5
Full changelog also available here:
https://github.com/albertogeniola/elmax-api/blob/main/CHANGELOG.md
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: