Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elmax_api to v0.0.5 #117693

Merged

Conversation

albertogeniola
Copy link
Contributor

Proposed change

Upgrade dependency elmax_api to 0.0.5. Needed for #117689.

Changes introduced to 0.0.5:
https://github.com/albertogeniola/elmax-api/releases/tag/v0.0.5

Full changelog also available here:
https://github.com/albertogeniola/elmax-api/blob/main/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2024.5.5 milestone May 18, 2024
@albertogeniola albertogeniola force-pushed the elmax/update_dependency_library branch from f5defff to b269b2a Compare May 18, 2024 14:44
@bdraco
Copy link
Member

bdraco commented May 20, 2024

It doesn't looks like there are any bugfixes in this lib bump that would require a backport. Does this need to be backported?

@albertogeniola
Copy link
Contributor Author

No, it doesn't. To fix the bug I am referring to, we also need to apply another (separate) PR (#117689)

@bdraco bdraco removed this from the 2024.5.5 milestone May 20, 2024
@bdraco bdraco merged commit 9fab2aa into home-assistant:dev May 20, 2024
38 checks passed
@bdraco
Copy link
Member

bdraco commented May 20, 2024

If #117689 gets tagged for backport, we can come back and tag this one. #117689 is probably too large to backport though and beta on the 29th so it might be better to wait for it to go though the normal release process.

@albertogeniola
Copy link
Contributor Author

albertogeniola commented May 20, 2024 via email

bajansen pushed a commit to bajansen/homeassistant that referenced this pull request May 20, 2024
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants