-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "Emoji" object in editor #358
base: release/1.3
Are you sure you want to change the base?
New "Emoji" object in editor #358
Conversation
looks very interesting and promising! |
Sure! 👉🏼Greenshot_emoji.zip 👈🏼 |
This is a great PR, I really like the result! I mean REALLY nice work!!!!! ❤️ I currently have only two things which are a challenge:
I'm not sure about what to do about the second item... |
If I double click, the emoji has a black area on the right side, and the picker is short first when you click again. |
Yes the edition is buggy, I'll dig deeper as it seems you have interest in the feature ;-) (The picker is a WPF button that displays a popup on click. So for now you need to click 3 times. As for the black background it's probably easy to fix) |
I'm definitively interested in this, I've been thinking about providing something like it via a collection of SVGs (it has to be vector graphics due to the scaling). This is especially needed for things like checkboxes etc., but also for emoji. The other containers have settings, like color, like thickness etc., in the toolbar under the destinations. I think for it to be consistent with the others, it would make sense to have it the same way. The double click is not directly bad, but it's a deviation to how others work. So if possible, we should provide a way to configure it in the toolbar. This would also solve the location issue with the selection. About the translations, if we just call it "Emoji", instead of "add emoji" we might not need any. This would solve a lot of troubles. |
Well it's similar to what is done with text edition. Also, it was easier for me to implement 😅
Consider it done. |
I agree for the text, as this is pretty much "inline" but providing a drop down or other window (like the color picker) is always done via the toolbar. I had a quick look at the license of the other project, this is always a very important thing... they need to fit. Some considerations I do have:
|
d26fa81
to
0d15124
Compare
I updated the PR with a few changes. I improved a lot the edition. Now it will display the popup by default when you create an Emoji and then you need to use the double-click. Let me know what you think. I had to make a very simple change in
While testing Lunacy it looks like the font system supports colored emoji by default so it should be easy. For the edition the best is probably to use the Windows Emoji picker but you need the app to target a recent windows SDK. And anyway the custom control in |
I just noticed that I also need to check the other dependencies, there seem to be more and I am not sure where they come from... |
that's weird, I didn't include it in the installer and it's working. It's used in a few places in the .xaml for Picker. https://github.com/samhocevar/emoji.wpf/blob/main/Emoji.Wpf/Picker.xaml#L7 Anyway it's from the same author and the licence is quite permissive: https://github.com/samhocevar/stfu/blob/main/COPYING |
ce7c2f8
to
4a635c4
Compare
New update, I fixed most of the issues I have in mind: |
Final tweaks on my side, I'm undrafting the PR as I'm happy with the result and the code.
|
Unfortunately it's not just about licenses, every dependency brings more work maintaining it and restricts my future work. If possible I prefer it without, if every PR would do so Greenshot would be a DLL hell on its own. I also still need to check the others, those with the glyphs. |
A lot of work sitting here -- would be nice to see it merged in. :-) |
You're right @wskellenger-intrepid, it's been a while now but I think we were not that far away from merging. I think we were trying to reduce the impact on the installer size. Embedding the font + the list of all emojis was increasing a lot the installer size. |
@Lakritzator I updated to emoji 14.0! |
a82df12
to
9372ac5
Compare
I just fixed it, it was a typo in your code. |
The same problem exists with rectangle - and other objects I guess. |
You mean when pressing Shift while resizing? By default, rectangles can be resized without any constraint. |
Correct, when pressing Shift. |
It's fixed too yeah, should I create another PR with just that fix? It's a one liner (see f6ca02b) |
This looks like it's approved but don't merge it yet. There's a very strong chance I'm launching a stable version of ImageSharp.Drawing today. |
Oh that's cool, I saw that you just released |
You're safe. v1.x of ImageSharp.Drawing will be compatible with ImageSharp v2.x only so will support net472. |
I do not know, sorry. |
b459bf8
to
2c7985e
Compare
2c7985e
to
50fb6e6
Compare
This allows to quickly insert emojis in the editor.
SixLabors.ImageSharp.Drawing
is used to do the rendering. Thx @JimBobSquarePants!Screenshots
TODO:
Emoji.WPF
)