Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new movie file if already exists #92067

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

morganwesemann
Copy link

This is branched off of #71420, which I think has been abandoned after asking on the PR back in March.

This PR implements the requested feedback on top of the original changes from the original PR to create a new movie file if the path already exists instead of overwriting. Thank you to the original author for opening the original PR, this is a feature I've been wanting!

This is the sample project I created for testing the code: https://github.com/morganwesemann/godot-movie-maker-test

This will close godotengine/godot-proposals#5989.

Here's what the setting looks like which defaults to true.
Movie_Test3

Multiple files for both .avi and .png extensions in the project movie file settings:
Movie_Test
Movie_Test2

Log output showing correct filename:

Movie Maker mode enabled, recording movie at 60 FPS...
----------------
Done recording movie at path: res://Movie.avi
25 frames at 60 FPS (movie length: 00:00:00), recorded in 00:00:03 (0% of real-time speed).
CPU time: 0.00 seconds (average: 0.11 ms/frame)
GPU time: 0.00 seconds (average: 0.01 ms/frame)
----------------

< more logs >

Movie Maker mode enabled, recording movie at 60 FPS...
----------------
Done recording movie at path: res://Movie_1.avi
31 frames at 60 FPS (movie length: 00:00:00), recorded in 00:00:03 (0% of real-time speed).
CPU time: 0.00 seconds (average: 0.10 ms/frame)
GPU time: 0.00 seconds (average: 0.01 ms/frame)
----------------

realkotob and others added 2 commits October 20, 2023 15:50
This makes the movie writer create new files instead of overwriting or deleting existing files.

Update doc/classes/ProjectSettings.xml

Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@morganwesemann morganwesemann marked this pull request as ready for review May 18, 2024 03:49
@morganwesemann morganwesemann requested a review from a team as a code owner May 18, 2024 03:49
@AThousandShips AThousandShips added this to the 4.x milestone May 18, 2024
@akien-mga akien-mga requested a review from Calinou May 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Movie Maker save to new file automatically if chosen file already exists
3 participants