Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add animations to block 6.1 of the English Curriculum #54852

Merged
merged 4 commits into from
May 21, 2024
Merged

feat(curriculum): add animations to block 6.1 of the English Curriculum #54852

merged 4 commits into from
May 21, 2024

Conversation

miyaliu666
Copy link
Member

Checklist:

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 17, 2024
@miyaliu666 miyaliu666 requested review from a team and DanielRosa74 May 17, 2024 05:41
@miyaliu666 miyaliu666 added scope: i18n language translation/internationalization. Often combined with language type label new english course English Curriculum labels May 17, 2024
@github-actions github-actions bot removed the scope: i18n language translation/internationalization. Often combined with language type label label May 21, 2024
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label May 21, 2024
DanielRosa74
DanielRosa74 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@DanielRosa74 DanielRosa74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added dialogues, fixed audio times pointed out by Miya, and changed challenge order to match sequence, as per Miya's suggestion. LGTM

@naomi-lgbt naomi-lgbt merged commit ebfc3d7 into freeCodeCamp:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosa74 DanielRosa74 DanielRosa74 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miyaliu666 @DanielRosa74 @naomi-lgbt