-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curriculum-build): add meta schema and normalize meta #54823
Merged
ShaunSHamilton
merged 5 commits into
freeCodeCamp:main
from
moT01:chore/remove-unused-meta
May 31, 2024
Merged
feat(curriculum-build): add meta schema and normalize meta #54823
ShaunSHamilton
merged 5 commits into
freeCodeCamp:main
from
moT01:chore/remove-unused-meta
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
scope: i18n
language translation/internationalization. Often combined with language type label
labels
May 15, 2024
moT01
added
the
status: blocked
Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
label
May 16, 2024
I'm gonna see if I can add some tests |
naomi-lgbt
approved these changes
May 20, 2024
moT01
force-pushed
the
chore/remove-unused-meta
branch
from
May 24, 2024 14:53
c144310
to
3d6688c
Compare
moT01
changed the title
chore: remove unused meta
feat(curriculum-build): add meta schema and normalize meta"
May 24, 2024
moT01
changed the title
feat(curriculum-build): add meta schema and normalize meta"
feat(curriculum-build): add meta schema and normalize meta
May 24, 2024
moT01
added
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
and removed
status: blocked
Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
labels
May 24, 2024
moT01
force-pushed
the
chore/remove-unused-meta
branch
from
May 28, 2024 13:09
3fb70e4
to
1b1c161
Compare
ShaunSHamilton
requested changes
May 30, 2024
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
ojeytonwilliams
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has validation ❤️. A+ would review again.
ShaunSHamilton
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
scope: i18n
language translation/internationalization. Often combined with language type label
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a schema validator for the meta.json files so there
isn't any inconsistenciesis less inconsistencies.It removes four things in the meta.json files:
template
values that are an empty stringrequired
values that are an empty arraytime
values that are an empty stringsuperOrder
valuesQuite sure they aren't needed.
Also, formats a few files to use two spaces instead of four.
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX