Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #106: Implementing skip-empty-xacts. #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bahaa
Copy link

@bahaa bahaa commented Jun 28, 2019

Adding new parameter skip-empty-xacts. I chose the same parameter name as Postgres' test_decoding.

This should resolve #106.

@joekohlsdorf
Copy link

What is the reasoning behind not defaulting this to true?

@bahaa
Copy link
Author

bahaa commented Aug 2, 2019

@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already.

@joekohlsdorf
Copy link

In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all.
They are just wasting network bandwidth and CPU cycles, depending on the use case this can require a substantial amount of additional processing.

@qweeze
Copy link

qweeze commented Feb 8, 2020

Any chance of merging this PR?

@eulerto
Copy link
Owner

eulerto commented Feb 10, 2020

@qweeze this PR is incomplete. It should be implemented in both format. @bahaa do you want to update this PR? Also, use a single commit.

@bahaa
Copy link
Author

bahaa commented Feb 10, 2020

@eulerto sure. I can update it on the weekend. What do you mean by "both formats"?

@jmealo
Copy link

jmealo commented Mar 31, 2020

@bahaa: there's an option format-version which can be either 1 or 2 (see README) -- anything new needs to support both versions.

@bahaa
Copy link
Author

bahaa commented Mar 31, 2020

@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend.

@ajitj
Copy link

ajitj commented Oct 25, 2020

Looking forward to getting this feature. @bahaa any update on this?
Thanks

@llehtinen
Copy link

@bahaa would be great to get this merged

@jehanzebqayyum
Copy link

@bahaa pls merge this.

@adrijshikhar
Copy link

@bahaa if you are unable to work on this, I will be more than happy to take it further.

@bahaa
Copy link
Author

bahaa commented Jun 15, 2022

@adrijshikhar sure. I'd be so glad if you do.

@adrijshikhar
Copy link

sure i will pick this up

@adrijshikhar
Copy link

#248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting an overwhelming amount of transactions with empty change sets despite using add-tables
9 participants