Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add overrides.namedExports to func-style rule #18444

Merged
merged 6 commits into from May 17, 2024
Merged

feat: add overrides.namedExports to func-style rule #18444

merged 6 commits into from May 17, 2024

Conversation

kecrily
Copy link
Member

@kecrily kecrily commented May 12, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

add overrides.namedExports to func-style rule

{
  "overrides":
    {
      "namedExports": "expression" | "declaration" | "ignore"
    }
}

close #12829

Is there anything you'd like reviewers to focus on?

@kecrily kecrily requested a review from a team as a code owner May 12, 2024 12:50
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label May 12, 2024
@netlify Netlify
Copy link

netlify bot commented May 12, 2024 •
edited

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 3d554d0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6640bafbac47660008a953b9
😎 Deploy Preview https://deploy-preview-18444--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the rule Relates to ESLint's core rules label May 12, 2024
@netlify Netlify
Copy link

netlify bot commented May 12, 2024 •
edited

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 9f57298
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6644e740a502ab00084fe95e
😎 Deploy Preview https://deploy-preview-18444--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Tanujkanti4441
Tanujkanti4441 requested changes May 12, 2024
View reviewed changes
docs/src/rules/func-style.md Outdated Show resolved Hide resolved
docs/src/rules/func-style.md Outdated Show resolved Hide resolved
docs/src/rules/func-style.md Show resolved Hide resolved
docs/src/rules/func-style.md Show resolved Hide resolved
docs/src/rules/func-style.md Show resolved Hide resolved
docs/src/rules/func-style.md Outdated Show resolved Hide resolved
docs/src/rules/func-style.md Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 12, 2024
Tanujkanti4441
Tanujkanti4441 requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule has an object option for an exception:

can you also change this line in docs as there are two options now?

docs/src/rules/func-style.md Outdated Show resolved Hide resolved
kecrily and others added 2 commits May 12, 2024 22:20
@kecrily @Tanujkanti4441
Apply suggestions from code review
a195ec3 
Co-authored-by: Tanuj Kanti <86398394+Tanujkanti4441@users.noreply.github.com>
@kecrily
docs: fix examples
8e037c1
@kecrily @mdjermanovic
Update lib/rules/func-style.js
84a88d8 
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
mdjermanovic requested changes May 13, 2024
View reviewed changes
lib/rules/func-style.js Outdated Show resolved Hide resolved
lib/rules/func-style.js Outdated Show resolved Hide resolved
lib/rules/func-style.js Outdated Show resolved Hide resolved
@ljharb ljharb mentioned this pull request May 14, 2024
Closed
mdjermanovic
mdjermanovic approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @Tanujkanti4441 to verify.

Tanujkanti4441
Tanujkanti4441 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit b32153c into main May 17, 2024
20 checks passed
@mdjermanovic mdjermanovic deleted the feat/func-style-overrides branch May 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@Tanujkanti4441 Tanujkanti4441 Tanujkanti4441 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

func-style "expression" conflicts with ESM named exports
3 participants
@kecrily @mdjermanovic @Tanujkanti4441