New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve message for ignored files without a matching config #18404
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
@@ -70,7 +70,7 @@ | |||
"@eslint-community/regexpp": "^4.6.1", | |||
"@eslint/eslintrc": "^3.0.2", | |||
"@eslint/js": "9.1.1", | |||
"@humanwhocodes/config-array": "^0.13.0", | |||
"@humanwhocodes/config-array": "github:humanwhocodes/config-array#pull/138/head", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated with a new version specifier.
lib/eslint/eslint-helpers.js
Outdated
message = "File ignored because of a matching ignore pattern. Use \"--no-ignore\" to disable file ignore settings or use \"--no-warn-ignored\" to suppress this warning."; | ||
} else { | ||
message = "File ignored because no matching configration was supplied."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message = "File ignored because no matching configration was supplied."; | |
message = "File ignored because no matching configuration was supplied."; |
Typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d15c087, thanks.
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
Still working on this. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18263
What changes did you make? (Give an overview)
Extended
createIgnoreResult
with an additional parameter that indicates whether a file has a matching configuration, in order to provide a better message when this is not the case. The value passed with this parameter is retrieved directly fromConfigArray
, which got a new methodisFileConfigured
for this purpose. See the PR inconfig-array
: humanwhocodes/config-array#138.Is there anything you'd like reviewers to focus on?