-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prefer to inherit observer classes privately #41360
Merged
ckerr
merged 19 commits into
main
from
refactor/prefer-to-inherit-observer-classes-privately
May 21, 2024
Merged
refactor: prefer to inherit observer classes privately #41360
ckerr
merged 19 commits into
main
from
refactor/prefer-to-inherit-observer-classes-privately
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
force-pushed
the
refactor/prefer-to-inherit-observer-classes-privately
branch
from
May 9, 2024 02:39
d801684
to
499c5f3
Compare
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
and removed
new-pr 🌱
PR opened in the last 24 hours
labels
May 10, 2024
codebytere
approved these changes
May 16, 2024
No Release Notes |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We have a lot of classes that inherit from upstream observer classes to manage internal state, e.g. our
AutofillDriverFactory
inherits fromcontent::WebContentsObserver
so that it can know when to close popups.Since
WebContentsObserver
inheritsAutofillDriverFactory
publicly, we are accidentally exposing a lot of public API (it's a 900+ LOC class!) toWebContentsObserver
's clients. We shouldn't do that; it might accidentally get used.This PR uses private inheritance instead..
Checklist
npm test
passesRelease Notes
Notes: none.