Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatability test for WITH DOCKER #4133

Merged
merged 1 commit into from
May 21, 2024

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented May 17, 2024

Introduces a new test for validating earthly v0.8.0 can work with the current version of earthly-buildkitd.

Fixes #4128

@alexcb alexcb force-pushed the acb/with-docker-backwards-compatability-test branch from a817ea5 to b513ada Compare May 17, 2024 22:31
@alexcb
Copy link
Collaborator Author

alexcb commented May 17, 2024

You can also run this locally against any versions, e.g. this reproduces the error:

earthly=earthly-v0.8.10 crustly=earthly-v0.8.9 ./backwards-compatability.sh

which produces:

          buildkitd | Found buildkit daemon as docker container (earthly-integration-buildkitd)
           buildkitd | Updated image available. But update was inhibited.
           buildkitd | Warning: Buildkit version (v0.8.10) is different from Earthly version (v0.8.9)

...

================================== ❌ FAILURE ===================================

././t/with-docker+empty-test *failed* | Repeating the failure error...
././t/with-docker+empty-test *failed* | --> WITH DOCKER RUN --privileged echo "dummy"
././t/with-docker+empty-test *failed* | /var/earthly/dockerd-wrapper.sh: line 80: EARTHLY_DOCKERD_CACHE_DATA: parameter not set
././t/with-docker+empty-test *failed* | ERROR ../../tests/with-docker/Earthfile line 23:8
././t/with-docker+empty-test *failed* |       The command
././t/with-docker+empty-test *failed* |           WITH DOCKER RUN --privileged echo "dummy"
././t/with-docker+empty-test *failed* |       did not complete successfully. Exit code 2
././t/with-docker+empty-test | unlazy force execution: process "/bin/sh -c EARTHLY_DOCKERD_DATA_ROOT=\"/var/earthly/dind/69b63098c23beedcaa2fbd5c887864c5d8a8f4d02f64752e7394e5dc20528d14\" EARTHLY_DOCKER_LOAD_FILES=\"\" EARTHLY_IMAGES_WITH_DIGESTS=\"\" EARTHLY_START_COMPOSE=\"false\" EARTHLY_COMPOSE_FILES=\"\" EARTHLY_COMPOSE_SERVICES=\"\" DIND_IMAGE=earthly/dind:alpine-3.19-docker-25.0.5-r0 OTEL_TRACES_EXPORTER=none PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin /var/earthly/dockerd-wrapper.sh execute /usr/bin/earth_debugger /bin/sh -c 'echo \"dummy\"'" did not complete successfully: exit code: 2

@alexcb alexcb force-pushed the acb/with-docker-backwards-compatability-test branch 7 times, most recently from a4a4cf4 to 36b6e21 Compare May 21, 2024 21:57
Introduces a new test for validating earthly v0.8.0 can work with the
current version of earthly-buildkitd.

Fixes #4128

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb force-pushed the acb/with-docker-backwards-compatability-test branch from 36b6e21 to 7927f1c Compare May 21, 2024 22:38
@alexcb alexcb marked this pull request as ready for review May 21, 2024 23:20
@alexcb alexcb requested a review from a team as a code owner May 21, 2024 23:20
fi

# used for testing backwards compatability issues
crustly="${crustly:=earthly-v0.8.0}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@alexcb alexcb merged commit c1b7d13 into main May 21, 2024
106 checks passed
@alexcb alexcb deleted the acb/with-docker-backwards-compatability-test branch May 21, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

WITH DOCKER breaks with EARTHLY_DOCKERD_CACHE_DATA: parameter not set
2 participants