Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy log sharing & associated code & tests #4129

Merged
merged 4 commits into from
May 28, 2024
Merged

Remove legacy log sharing & associated code & tests #4129

merged 4 commits into from
May 28, 2024

Conversation

mikejholly
Copy link
Contributor

No description provided.

alexcb
alexcb reviewed May 17, 2024
View reviewed changes
cmd/earthly/app/before.go Outdated Show resolved Hide resolved
alexcb
alexcb reviewed May 17, 2024
View reviewed changes
cmd/earthly/app/before.go Outdated Show resolved Hide resolved
@mikejholly mikejholly marked this pull request as ready for review May 28, 2024 19:04
@mikejholly mikejholly requested a review from a team as a code owner May 28, 2024 19:04
@mikejholly
Copy link
Contributor Author

@alexcb @vladaionescu Ok to merge?

alexcb
alexcb approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge away!

@mikejholly mikejholly merged commit 74c20db into main May 28, 2024
192 checks passed
@mikejholly mikejholly deleted the mh/remove-legacy-logs branch May 28, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcb alexcb alexcb approved these changes

@vladaionescu vladaionescu Awaiting requested review from vladaionescu

Assignees
No one assigned
Labels
None yet
Projects
core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikejholly @alexcb