Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Voice Channel Send Effects #9288

Merged
merged 14 commits into from
Jun 3, 2024
Merged

feat: Voice Channel Send Effects #9288

merged 14 commits into from
Jun 3, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Mar 28, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:46am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:46am

@vercel
Copy link

vercel bot commented Mar 28, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@Jiralite Jiralite changed the title feat: initial commit feat: Voice Channel Send Effects Mar 28, 2023
@Jiralite Jiralite added this to the discord.js 14.10 milestone Mar 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-jiralite-feat-voice-effects-discordjs.vercel.app/

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Mar 28, 2023 •
edited

may you add channel getter?

@Jiralite Jiralite removed the request for review from SpaceEEC April 16, 2023 23:20
@Jiralite Jiralite changed the base branch from main to feat/v-c-s-e June 3, 2024 01:44
@Jiralite Jiralite removed this from the discord.js 14.16 milestone Jun 3, 2024
@Jiralite Jiralite marked this pull request as ready for review June 3, 2024 01:52
@Jiralite Jiralite requested a review from a team as a code owner June 3, 2024 01:52
@Jiralite Jiralite requested review from vladfrangu, iCrawl, kyranet and SpaceEEC and removed request for a team, vladfrangu, iCrawl, kyranet and SpaceEEC June 3, 2024 01:52
@Jiralite Jiralite merged commit 51399e4 into discordjs:feat/v-c-s-e Jun 3, 2024
6 checks passed
@Jiralite Jiralite deleted the feat/voice-effects branch June 3, 2024 01:53
@Jiralite Jiralite removed the blocked label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k left review comments

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jiralite @jaw0r3k