Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document modal update message callbacks #5988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MinnDevelopment
Copy link
Contributor

No description provided.

Copy link
Contributor

@VelvetToroyashi VelvetToroyashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! :)

@valdotle
Copy link
Contributor

I think having one disclaimer infobox instead of duplicate ones would do the job as well. However, since I couldn't figure out how to make this suggestion directly within in this pr, I opened another one on the original fork / branch: MinnDevelopment#1

@MinnDevelopment
Copy link
Contributor Author

@Valle-infinitare documenting it on that endpoint reduces discoverability since you do not have to use it for replies.

@valdotle
Copy link
Contributor

@Valle-infinitare documenting it on that endpoint reduces discoverability since you do not have to use it for replies.

Fair. However, I still think having multiple infoboxes would be slightly unnecessary as there'd be multiple of them visible showing the same information in certain instances.
Maybe linking initial response to interaction response create would work better then.
On the other hand it's only 3 of them and they aren't taking that much space or anything so it's not worth arguing about it too much...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants