-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Localized Templates): ability to register user and set language,… #22452
Draft
rbochenski
wants to merge
5
commits into
directus:main
Choose a base branch
from
rbochenski:ability-to-have-language-based-email-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5834fd1
feat(Localized Templates): ability to register user and set language,…
rbochenski acdd202
feat(Localized Templates): fix formatting;
rbochenski a48d620
feat(Localized Templates): fix lint;
rbochenski 69779ae
feat(Localized Templates): fix tests;
rbochenski 20b4957
feat(Localized Templates): sign to contributors;
rbochenski File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,3 +126,4 @@ | |
- the-other-dev | ||
- magiudev | ||
- burka | ||
- rbochenski |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation would mean that we would have to manually translate every single email template into every single language that we support in raw HTML. Imagine then needing to update a small thing like the styling - we would have to go through each template individually and update them all for all languages.
It'd be better if we could reuse our existing community translation integration so everyone benefits from our diverse community and would enable us to change styles/layouts without touching every single language. :)
That has been, amongst other things, mentioned yesterday here and another approach here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for response.
I understand that yet it might happen that for different languages especially for right to left you would like to have a but different views.
So with such solution we can have both, what you propose and different templates for different languages.
Also consider situation where for some languages you might want to have different colors of buttons or so.
Proposed implementation is not conflicting with your idea, just gives additional possibilities.
This comment was marked as duplicate.
Sorry, something went wrong.