Fix primary key unique constraint error extraction for MySQL #22434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
MySQL does some weird stuff for primary key unique constraints errors, where it doesn't actually tell us the primary key, but instead yells
PRIMARY
at us. Handle this case in the error extraction logic and propagate that info up the stack to where we actually have the info about the primary key field name.Additionally MySQL 5.7 won't even tell us the collection we're dealing with, so we have to add that in as well...
What's changed:
primaryKey
flag to theRecordNotUniqueError
extensions to propagate error infoPotential Risks / Drawbacks
None
Review Notes / Questions
translateDatabaseError
function? I'm not sure 馃Fixes #15033