-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up error handler & fix message for unknown API errors #22379
Open
paescuj
wants to merge
12
commits into
main
Choose a base branch
from
enhance-api-error-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+328
−65
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 541f5d0 - Browse repository at this point
Copy the full SHA 541f5d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ef696 - Browse repository at this point
Copy the full SHA a0ef696View commit details -
Slightly more readable stack check
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8df1a9f - Browse repository at this point
Copy the full SHA 8df1a9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aac062 - Browse repository at this point
Copy the full SHA 4aac062View commit details -
Configuration menu - View commit details
-
Copy full SHA for 236c6a9 - Browse repository at this point
Copy the full SHA 236c6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c19cd - Browse repository at this point
Copy the full SHA 21c19cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6950c6 - Browse repository at this point
Copy the full SHA c6950c6View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e5a045 - Browse repository at this point
Copy the full SHA 0e5a045View commit details
Commits on May 29, 2024
-
Ensure error.code cannot be overwritten
Co-authored-by: Brainslug <tim@brainslug.nl>
Configuration menu - View commit details
-
Copy full SHA for f2d8038 - Browse repository at this point
Copy the full SHA f2d8038View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e80671c - Browse repository at this point
Copy the full SHA e80671cView commit details -
Enhance asyncErrorHandler signature & handler call
- Omit Promise.resolve as we know we receive a promise in this case - Use args from ErrorRequestHandler
Configuration menu - View commit details
-
Copy full SHA for d07bed1 - Browse repository at this point
Copy the full SHA d07bed1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d76629c - Browse repository at this point
Copy the full SHA d76629cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.