Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime/windows): (WinOS) Fix calculation of console size #23873

Open
wants to merge 2 commits into
base: v1.43
Choose a base branch
from
Open

fix(runtime/windows): (WinOS) Fix calculation of console size #23873

wants to merge 2 commits into from

Conversation

rivy
Copy link
Contributor

@rivy rivy commented May 17, 2024

Fixes #23872.

@rivy
Copy link
Contributor Author

rivy commented May 17, 2024

I haven't implemented an underflow check for the subtractions, but I can if requested.

@rivy
Copy link
Contributor Author

rivy commented May 21, 2024 •
edited

I read the docs a bit closer and decided that over/under-flow protection was warranted given the vagueness.
Return will be either correct, or, if bad values are received, { cols: 0, rows: 0 }.

littledivy
littledivy reviewed May 23, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

runtime/ops/tty.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rivy @littledivy