fix(ext/webgpu): Allow depthClearValue to be undefined when depthLoadOp is not "clear"
#23850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirsz-ever
force-pushed
the
chirsz/fix-beginpass-240517
branch
from
580d058
to
a23788d
Compare
|
@crowlKats Could you please review this PR? |
|
@chirsz-ever looks good, though a simple unit test would be nice |
chirsz-ever
force-pushed
the
chirsz/fix-beginpass-240517
branch
from
a23788d
to
a5dea5e
Compare
|
A new unit test added in "tests/unit/webgpu_test.ts". |
…oadOp` is not "clear" Add a new unit test in "tests/unit/webgpu_test.ts".
chirsz-ever
force-pushed
the
chirsz/fix-beginpass-240517
branch
from
a5dea5e
to
2cf21a4
Compare
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
…oadOp` is not "clear" (#23850)
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
…oadOp` is not "clear" (#23850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implemention would panic at
op_webgpu_command_encoder_begin_render_passwith legal JavaScript code, becauseGpuRenderPassDepthStencilAttachmentrequiredepth_clear_valueto always appear.The current WebGPU specification says1
The modification is tiny and easy to understand. Should I open a issue and/or add a unit test?
Footnotes
https://gpuweb.github.io/gpuweb/#dom-gpurenderpassdepthstencilattachment-depthclearvalue ↩