fix(ext/web): Fix abort signal timeout leak #23842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
#20663 is saying that a test like this should pass. Deno.test({
name: "regression for #20663",
fn: () => {
AbortSignal.timeout(2000);
},
}); |
mmastrac
reviewed
May 16, 2024
| @@ -120,6 +120,7 @@ class AbortSignal extends EventTarget { | |||
| const signal = new AbortSignal(illegalConstructorKey); | |||
| signal[timerId] = setTimeout( | |||
There was a problem hiding this comment.
Note that Deno.core offers a queueSystemTimer to work around this sort of issue. Even with the changes made here, we will still be leaking a timer, as the timer is only ever cleared when the timer has fired (which should have already cleared the timer).
mmastrac
reviewed
May 16, 2024
| name: "regression for #20663", | ||
| fn: async () => { | ||
| const signal = AbortSignal.timeout(2000); | ||
| const t = setTimeout(() => { |
There was a problem hiding this comment.
To properly test this fix, I believe you should create an AbortSignal.timeout and let it just leak out of the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20663.