Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable pointer compression via deno_core bump #23838

Merged
merged 3 commits into from
May 23, 2024

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented May 16, 2024

v8 12.6 w/pointer compression enabled.

Closes #18935

@mmastrac mmastrac added the ci-bench put this on a PR to run the benchmarks label May 16, 2024
bartlomieju added a commit that referenced this pull request May 21, 2024
#23838 might accidentally disable
import assertions support because of V8 12.6 unshipping it, but we want
import assertions to be supported until Deno 2.
bartlomieju added a commit that referenced this pull request May 21, 2024
#23838 might accidentally disable
import assertions support because of V8 12.6 unshipping it, but we want
import assertions to be supported until Deno 2.
bartlomieju added a commit that referenced this pull request May 21, 2024
#23838 might accidentally disable
import assertions support because of V8 12.6 unshipping it, but we want
import assertions to be supported until Deno 2.
@mmastrac mmastrac changed the title chore: deno_core bump [WIP] chore: enable pointer compression via deno_core bump May 22, 2024
@mmastrac mmastrac changed the title chore: enable pointer compression via deno_core bump feat: enable pointer compression via deno_core bump May 22, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's land and evaluate what benchmarks show.

Nitpick: I would say this is chore: upgrade deno_core but not a big deal :D

@mmastrac
Copy link
Contributor Author

LGTM, let's land and evaluate what benchmarks show.

Nitpick: I would say this is chore: upgrade deno_core but not a big deal :D

I originally had that, but it seems like a reasonably important feature to note in the release notes :)

@mmastrac mmastrac enabled auto-merge (squash) May 23, 2024 00:37
@mmastrac mmastrac merged commit b009c84 into denoland:main May 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-bench put this on a PR to run the benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.33.1 now requires --v8-flags=--max-old-space-size=8192 to prevent OOME
2 participants