Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add business_hours support for sla evaluation #9470

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented May 15, 2024

Pull Request Template

Description

  • Add support for respecting the business_hour setting in SLA policies

Changelog

  • Business hours are used in evaluation only if the inbox configures business hours and a conversation is applied with an SLA policy that has only_during_business_hours set to true.
  • If either inbox or sla_poliicy is missing business_hours, this will be evaluated normally

Fixes https://linear.app/chatwoot/issue/CW-3051/handle-business-hours-during-sla-evaluation

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Add new specs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

linear bot commented May 15, 2024

@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9470 May 15, 2024 14:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant