Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(future.py): add tests and fixes #22461

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

carlosmiei
Copy link
Collaborator

@carlosmiei carlosmiei commented May 10, 2024

@carlosmiei carlosmiei self-assigned this May 10, 2024
@carlosmiei carlosmiei closed this May 11, 2024
@carlosmiei carlosmiei reopened this May 11, 2024
@carlosmiei carlosmiei closed this May 13, 2024
@carlosmiei carlosmiei reopened this May 13, 2024
@carlosmiei
Copy link
Collaborator Author

If it test poloniexfutures I get different errors repeatedly...

e "/Users/cjg/Git/ccxt15/ccxt/python/ccxt/pro/poloniexfutures.py", line 751, in handle_l2_order_book
    self.handle_delta(orderBook, data)
  File "/Users/cjg/Git/ccxt15/ccxt/python/ccxt/pro/poloniexfutures.py", line 823, in handle_delta
    raise InvalidNonce(self.id + ' watchOrderBook received an out-of-order nonce')
ccxt.base.errors.InvalidNonce: poloniexfutures watchOrderBook received an out-of-order nonce

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/cjg/Git/ccxt15/ccxt/python/ccxt/pro/test/base/test_close.py", line 73, in <module>
    run(test_close())
  File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt15/ccxt/python/ccxt/pro/test/base/test_close.py", line 59, in test_close
    assert False
AssertionError
Task was destroyed but it is pending!
task: <Task pending name='Task-25' coro=<Throttler.looper() done, defined at /Users/cjg/Git/ccxt15/ccxt/python/ccxt/async_support/base/throttler.py:21> wait_for=<Future pending cb=[Task.task_wakeup()]>>
poloniexfutures requires to release all resources with an 

@pcriadoperez
Copy link
Contributor

I tested with the latest changes from master and the poloniexfutures errors doesn't show up anymore

@carlosmiei carlosmiei merged commit 8a297b3 into ccxt:master May 22, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants