Split out base settings in stdlib for reuse #493
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
pkl:AbstractSettings
as a common parent module forpkl:settings
andpkl:Project
.Since user-level evaluator settings should be limited to user/machine specific ones (to avoid unnecessary "works on my machine"), whereas
PklProject
s might want to set more detailed settings.There isn't an overwhelming win from making
pkl:AbstractSettings
a super-module, other thanevaluatorSettings
(and possibly other properties in the future) being defined in all children by default. Alternatively,pkl:AbstractSettings
could define allclass
es that might be used somewhere, and it just beingimport
ed, i.e.settings.pkl
:Project.pkl
: