-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Snowflake Cortex: SQL Processor Refactor #38337
Destination Snowflake Cortex: SQL Processor Refactor #38337
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
for i, chunk in enumerate(document_chunks, start=0): | ||
new_data: dict[str, Any] = { | ||
DOCUMENT_ID_COLUMN: self._create_document_id(record_msg), | ||
CHUNK_ID_COLUMN: str(uuid.uuid4().int), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
- Consider changing this to int or ULID.
...ons/connectors/destination-snowflake-cortex/destination_snowflake_cortex/cortex_processor.py
Outdated
Show resolved
Hide resolved
β¦//github.com/airbytehq/airbyte into aj/destination-cortex/sql-processor-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took another pass. Looks great! π We should make sure all the tests run before we merge.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?