Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Woocommerce: changes for builder compatibility #38334

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

strosek
Copy link
Contributor

@strosek strosek commented May 17, 2024

What

As part of the builder-compatible and silver certification. This PR creates a manifest, migrates to poetry and deletes old spec and schemas. New PR to avoid conflict with Brian's.

How

Migration to poetry, created a builder-generated manifest.yaml, deleted spec and schemas. Upgraded CDK to v0.88.

Review guide

manifest.yaml - created, integrated spec and generated with builder.
pyproject.toml - migrated to poetry and updated CDK dependency.
Deleted schemas and old spec.
metadata.yaml - added maxSecondsBetweenMessages
test_core.py - fixed CAT tests for clean CI.

User Impact

Able to use builder, general quality improvements.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@strosek strosek requested review from girarda and maxi297 May 17, 2024 22:05
@strosek strosek self-assigned this May 17, 2024
@strosek strosek requested review from lazebnyi, oustynova and a team as code owners May 17, 2024 22:05
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 10:05pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/woocommerce labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/woocommerce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants