Making mass upgrades easier in airbyte ci #38333
Closed
+178
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
natikgadzhi
reviewed
May 17, 2024
| @@ -142,7 +153,7 @@ def __init__( | |||
|
|
|||
| async def get_repo_dir(self) -> Directory: | |||
| if not self.repo_dir: | |||
| self.repo_dir = await self.context.get_connector_dir() | |||
| self.repo_dir = await self.context.get_repo_dir() | |||
There was a problem hiding this comment.
Uh, I wonder how that would never get caught in prod / tests
| @@ -42,18 +42,23 @@ | |||
| default=False, | |||
| help="Create a pull request.", | |||
| ) | |||
|
|
|||
| @click.option( | |||
There was a problem hiding this comment.
Should we make this consistent with migrate_to_poertry and migrate_to_base_image so that they all have --bump?
|
I've merged these in, but in a separate PR 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.