-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code #38316
base: master
Are you sure you want to change the base?
🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code #38316
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…pe for dimensions transformations
else: | ||
stream_state = stream_states[0] | ||
kwargs = {"stream_state": stream_state, "stream_slice": stream_slice, "next_page_token": next_page_token} | ||
return [record for record in records if self._filter_interpolator.eval(self.config, record=record, **kwargs)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to align with original signature (Iterable)
|
||
requester: | ||
type: HttpRequester | ||
url_base: '{{ "https://sandbox-ads.tiktok.com/open_api/v1.3/" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "https://business-api.tiktok.com/open_api/v1.3/" }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url_base: '{{ "https://sandbox-ads.tiktok.com/open_api/v1.3/" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "https://business-api.tiktok.com/open_api/v1.3/" }}' | |
url_base: '"https://{{ "sandbox-ads" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "business-api" }}.tiktok.com/open_api/v1.3/"' |
nit
type: DpathExtractor | ||
field_path: ["data", "list"] | ||
|
||
record_selector_with_filter_by_midify_time: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
record_selector_with_filter_by_midify_time: | |
record_selector_with_filter_by_modify_time: |
What
resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/7824
How
Migrated source to use low-code cdk instead of python cdk.
Main changes:
lifetime=true
as request param, which is deprecated on API v1.3. Now lifetime reports usequery_lifetime=true
, with this param start_date and end_date should not be provided. Exception: advertiser_lifetime_report: API v1.3 doesn't allow query_lifetime=true` with advertiser reports, so this stream was implemented exactly as in py version with start_date and end_date query params(range >=365d)Review guide
User Impact
Breaking change users will need to follow migration guide for affected streams.
Can this PR be safely reverted and rolled back?
Breaking change due to changes in schema and state format.