Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨🎉Source LinkedIn Ads: migrate to low-code #38314

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented May 17, 2024

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/7804

How

We have migrated streams to a low-code platform. However, the analytics streams remain in Python, as the low-code implementation requires custom logic for slicing, parsing records, and mapping records that were sliced into fields by chunks.

Review guide

  1. manifest.yaml
  2. source.py

User Impact

Format of state has changed for incremental streams, primary key has changed for account_users stream

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 11:50pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 17, 2024
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented May 17, 2024

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

…f github.com:airbytehq/airbyte into lazebnyi/7804-source-linkedin-ads-migrate-to-lowcode
@lazebnyi lazebnyi marked this pull request as ready for review May 26, 2024 23:32
@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 26, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants