Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mssql: fix cursor value query #38292

Merged
merged 4 commits into from
May 30, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented May 16, 2024

What

Fixes airbytehq/airbyte-internal-issues#7772

How

Changes a SQL query to return only one row.

User Impact

Might reduce OOMs, otherwise nothing.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 1:42pm

@postamar postamar marked this pull request as ready for review May 16, 2024 19:14
@postamar postamar requested a review from a team as a code owner May 16, 2024 19:14
@postamar
Copy link
Contributor Author

Thanks for the review! Updating this PR with a recent master before merging, just to make sure, as this has grown a bit stale.

@postamar postamar force-pushed the postamar/source-mssql-fix-cursor-query branch from b70f727 to 870a19a Compare May 30, 2024 13:38
@postamar postamar merged commit 25db2e0 into master May 30, 2024
32 checks passed
@postamar postamar deleted the postamar/source-mssql-fix-cursor-query branch May 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants