Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (cx_Oracle.DatabaseError) ORA-00904 #1161

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

eaandersen
Copy link
Contributor

@eaandersen eaandersen changed the title Main Fix (cx_Oracle.DatabaseError) ORA-00904 May 17, 2024
@gventuri
Copy link
Collaborator

@eaandersen thanks a lot for the PR. To keep it cleaner, would you mind creating a Oracle connector extending the SQL connector that overrides the default value for rand? That would be a cleaner and easier to maintain solution.

@eaandersen
Copy link
Contributor Author

@eaandersen thanks a lot for the PR. To keep it cleaner, would you mind creating a Oracle connector extending the SQL connector that overrides the default value for rand? That would be a cleaner and easier to maintain solution.

It makes perfect sense to extend the SQLConnector and create a separate class for Oracle. I'll send an update in the next day or two.

@gventuri
Copy link
Collaborator

@eaandersen thanks a lot, really appreciated!

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 18, 2024
@eaandersen
Copy link
Contributor Author

@eaandersen thanks a lot, really appreciated!

Updates completed. I created a separate class for Oracle, extending the SQL connector. Added required unit tests and everything passed. Also added a check for connection close to avoid NoneType errors. Updated TOML with optional cx_Oracle. Let me know if you're okay with these changes.

@gventuri
Copy link
Collaborator

@eaandersen thanks a lot for the changes, seems good. Running the CI, will merge as soon as it passes!

@gventuri gventuri merged commit ac59d8b into Sinaptik-AI:main May 18, 2024
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cx_Oracle.DatabaseError) ORA-00904: "RAND": invalid identifier
2 participants