Guild Scheduled Event Recurrence & Exceptions #9685
Draft
+273
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump (not sure if it is correct to, my bad if so) |
AbstractUmbra
suggested changes
Jun 7, 2024
discord/scheduled_event.py
Outdated
|
|
||
| def __eq__(self, other: object) -> bool: | ||
| if isinstance(other, self.__class__): | ||
| return self.exception_ids == other.exception_ids |
There was a problem hiding this comment.
This is currently an AttributeError?
discord/scheduled_event.py
Outdated
Comment on lines
121
to
123
| For example, if you want for this event to repeat the 1st Monday of the month, | ||
| then this param should have a value of `(1, 0)`. Where ``1`` represents the | ||
| 'first' and ``0`` the weekday, in this case, Monday. |
There was a problem hiding this comment.
Instead of an example easily missed here, why not do something like this with a few (small) examples.
discord/scheduled_event.py
Outdated
| ) | ||
| return NotImplemented | ||
|
|
||
| def __set_interval(self, value: int) -> None: |
There was a problem hiding this comment.
It's uncommon for discord.py to use name mangling on private methods like this. Any particular reason we added it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now I added a local to ignore docs lol, so no more problems
This PR adds support for Guild Scheduled Event recurrence and exceptions.
This will stay draft until it gets documented on the Discord API Docs
Checklist