Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace declarative_mixin with DeclarativeBase for all models #13448

Merged
merged 2 commits into from
May 20, 2024

Conversation

bunchesofdonald
Copy link
Contributor

This is the first in what is likely to be a long series of PRs that remove the models from the database abstraction layer. This PR:

  • Makes the models use a DeclarativeBase instead of declarative_mixin.
  • Updates many of the models files to use orm_models.<model> directly.
  • Removes usages of PrefectDBInterface in filters and sorting.

Related to #11795

@bunchesofdonald bunchesofdonald added the maintenance Chores and other work not directly related to the product label May 17, 2024
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I did see some test suite snags but they mostly look like trivial call signature catchups after removing db.

@bunchesofdonald
Copy link
Contributor Author

Thanks! I'll get those tests passing this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants