Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecated functions and model fields #13378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aaazzam
Copy link
Contributor

@aaazzam aaazzam commented May 15, 2024

This removes a littany of deprecated fields, including PREFECT_CLOUD_URL from settings (which is why it touched frontend stuff)

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buhbye

@aaazzam
Copy link
Contributor Author

aaazzam commented May 15, 2024

wait does this require db migrations @chrisguidry ?

@chrisguidry
Copy link
Collaborator

I don't believe so, but maybe some of these fields are on client-side models that aren't marked deprecated? The output was very noisy but I see some complaints about providing extra fields from a client-side call to the server

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

@github-actions github-actions bot added the status:stale This may not be relevant anymore label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale This may not be relevant anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants