fix: recommended templates should link to template view #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannemarik
changed the title
MarvinPerry
approved these changes
May 20, 2024
esri-dcdev-2
pushed a commit
that referenced
this pull request
May 23, 2024
## @esri/hub-common [14.133.2](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.133.1...@esri/hub-common@14.133.2) (2024-05-23) ### Bug Fixes * recommended templates should link to template view ([#1519](#1519)) ([c1ceb99](c1ceb99))
esri-dcdev-2
pushed a commit
that referenced
this pull request
May 29, 2024
## [14.1.1](https://github.com/Esri/hub.js/compare/@esri/hub-teams@14.1.0...@esri/hub-teams@14.1.1) (2024-05-29) ### Bug Fixes * add e2e to verify site + domain removal ([#1531](#1531)) ([e8dd093](e8dd093)) * add siteRelativeEntityType link to multiple entities ([#1522](#1522)) ([6557279](6557279)) * deepFilter allows for blobs to pass through ([#1524](#1524)) ([b689529](b689529)) * limit project content and events to qa alpha ([#1525](#1525)) ([ddc32d6](ddc32d6)) * remove entityOwner check from template settings permission ([#1520](#1520)) ([6d34101](6d34101)) * **hub-common:** add IAssociation, update IEvent with associations, a… ([#1498](#1498)) ([2562bd2](2562bd2)) * **hub-common:** fix force content endpoint ([#1509](#1509)) ([f0283f0](f0283f0)) * **hub-common:** fixes issue where derived entity location for site o… ([#1523](#1523)) ([7b47641](7b47641)) * broaden check for isDiscussable to handle falsey, not just undefined ([#1487](#1487)) ([a298ba3](a298ba3)) * export IWithFollowers ([#1489](#1489)) ([6455b42](6455b42)) * recommended templates should link to template view ([#1519](#1519)) ([c1ceb99](c1ceb99)) * **hub-common:** enable editing for past events ([#1521](#1521)) ([8d66da4](8d66da4)) * 9948 stat card editor error messaging ([#1472](#1472)) ([02119ee](02119ee)) * add content to site propertyMap, allow more props on ICapabilityConfig ([#1508](#1508)) ([c947301](c947301)) * add helper texts and remove "Favorite" filter in follow card editor ([#1466](#1466)) ([6e928b5](6e928b5)) * initiative fromEditor creates new initiatives before attempting … ([#1503](#1503)) ([bbef6ab](bbef6ab)) * remove alpha gating from templates ([#1514](#1514)) ([25fcca6](25fcca6)) * **hub-common:** add event icon to getContentTypeIcon method ([#1463](#1463)) ([09b675d](09b675d)) * **hub-common:** add permission object to IEvent and IRegistration ([#1448](#1448)) ([fc32def](fc32def)) * **hub-common:** add startDate, startTime, endDate, endTime to create… ([#1480](#1480)) ([74b4634](74b4634)) * **hub-common:** add status to IUpdateEvent ([#1469](#1469)) ([c44b99d](c44b99d)) * **hub-common:** fix createHubEvent method and property mappings ([#1496](#1496)) ([944dcb8](944dcb8)) * **hub-common:** fix the target api url in getSchedule(), setSchedule(), etc ([#1485](#1485)) ([c820942](c820942)) * **hub-common:** fix undefined token when getSchedule is called ([#1505](#1505)) ([9be1d5f](9be1d5f)) * **hub-common:** fix undefined token when getting schedule ([#1506](#1506)) ([7f8c782](7f8c782)) * **hub-common:** fix unified list feature flag, format order, and additional resource calculation ([#1501](#1501)) ([46d4715](46d4715)) * **hub-common:** get events by groupid types ([#1513](#1513)) ([b8d46a8](b8d46a8)) * **hub-common:** get-events dto enum array types ([#1507](#1507)) ([fb2e67a](fb2e67a)) * add local copies of calcite-web css and js files ([#1453](#1453)) ([7a60503](7a60503)) * add prod alpha orgs to hub:feature:workspace ([#1423](#1423)) ([f1104a2](f1104a2)) * add url validator ([#1451](#1451)) ([54956d7](54956d7)) * await uiSchema build ([#1428](#1428)) ([8af4f48](8af4f48)) * ensure sites have telemetry ([#1430](#1430)) ([abc5205](abc5205)) * findItemsBySlug short-circuits to resolve empty array when slug is falsey ([#1420](#1420)) ([f255f6e](f255f6e)) * gate the new follow card behind the feature flag ([#1419](#1419)) ([92626e7](92626e7)) * initiatives can be edited by premium and basic users ([#1443](#1443)) ([9dce7d0](9dce7d0)) * isDiscussable handles undefined subject ([#1486](#1486)) ([d9ea92a](d9ea92a)) * metric/stat card schema sourceLink does url validation ([#1461](#1461)) ([8e398d0](8e398d0)) * proper export path for schedule interfaces ([#1478](#1478)) ([b0c10bb](b0c10bb)) * remove unused scope on subblock section in stat card editor uiSchema ([#1431](#1431)) ([9389cd8](9389cd8)) * support old web mapping application sites in workspaces ([#1442](#1442)) ([ede26c4](ede26c4)) * update can-edit-event to work in cases where initiative is deleted ([#1474](#1474)) ([a07470b](a07470b)) * update followSchema and followCardUiSchema ([#1455](#1455)) ([7da4122](7da4122)) * updates well known types to fix gallery query ([#1492](#1492)) ([24f0f97](24f0f97)) * **hub-common:** restrict temp:hub:content:downloads:unifiedList to be behind a feature flag ([#1495](#1495)) ([d53f50f](d53f50f)) * update fetchHubGroup ro and follow card permission ([#1484](#1484)) ([ef3cabb](ef3cabb)) * update unfollow button to outline-fill ([#1462](#1462)) ([0427e81](0427e81)) * **hub-common:** add tags and categories to events ([#1452](#1452)) ([d0a6284](d0a6284)) * **hub-common:** fix discussion board and survey permissions ([#1449](#1449)) ([2d56088](2d56088)) * add call to action to project edit uiSchema ([#1369](#1369)) ([59e2a57](59e2a57)) * add clearOnHidden to values in metrics ([#1393](#1393)) ([311ad2a](311ad2a)) * add data.telemetry to site draft include list; redo telemetry config migration ([#1306](#1306)) ([a00818b](a00818b)) * add incremental delay and comments to poll util ([#1266](#1266)) ([07be412](07be412)) * add permission for project associations ([#1404](#1404)) ([ca42602](ca42602)) * address issue importing from a file thats not checked in ([#1289](#1289)) ([ead47f4](ead47f4)) * adds label to site telemetry ui schema section ([#1363](#1363)) ([6e29ddc](6e29ddc)) * alpha-gate overview and remove extra util ([#1396](#1396)) ([b1bc126](b1bc126)) * checkPermission tolerates context without userHubSettings ([#1416](#1416)) ([f9e7669](f9e7669)) * checkPermission uses userHubSettings.preview flags ([#1358](#1358)) ([e6ee056](e6ee056)) * config editor cleanup - update schemas ([#1377](#1377)) ([f531ee5](f531ee5)) * constructSlug accounts for typekeyword max length of 256 chars ([#1410](#1410)) ([c7465a0](c7465a0)) * deployed solution redirects ([#1268](#1268)) ([8df3607](8df3607)) * enable featured image alt text on hub initiative ([#1350](#1350)) ([669f0d8](669f0d8)) * explicitly say control for stat card uiSchema ([#1387](#1387)) ([a92acff](a92acff)) * fix the keyboard permission! ([#1409](#1409)) ([078d606](078d606)) * image description in hero title select ([#1380](#1380)) ([0693f24](0693f24)) * initiative UI schema enhancement ([#1359](#1359)) ([df303a3](df303a3)) * permissions for settings pane related to allow all editors ([#1446](#1446)) ([f511e50](f511e50)) * project/initiatives use upsertResource ([#1388](#1388)) ([8e3aabc](8e3aabc)) * remove group sharing ([#1415](#1415)) ([d0bb1c1](d0bb1c1)) * **hub-common:** refactor hubSearchChannels for more general use ([#1398](#1398)) ([8aba9aa](8aba9aa)) * add guards around excape predicate to avoid exceptions ([#1324](#1324)) ([a96f1ad](a96f1ad)) * add metrics-coming-soon permission ([#1317](#1317)) ([9b505c9](9b505c9)) * hub:feature:privacy is gated to devext ([#1313](#1313)) ([2e1832a](2e1832a)) * migrate malformed basemap hash resulting from hub.py bug ([#1381](#1381)) ([b68da32](b68da32)) * remove undefined from schemas ([#1362](#1362)) ([abd493f](abd493f)) * reorder fields in initiative editor, hide featured content for MVP ([#1364](#1364)) ([dae8911](dae8911)) * require title and require value if static ([#1373](#1373)) ([6231438](6231438)) * setFeaturedImage can now clear out orphaned featured image resou… ([#1378](#1378)) ([910b2ea](910b2ea)) * switch null to empty string for membershipAccess ([#1321](#1321)) ([85e85d3](85e85d3)) * tempoarily remove call to action from project edit uiSchema ([#1367](#1367)) ([b8175be](b8175be)) * update check for metricDisplays to have default ([#1310](#1310)) ([ca1701c](ca1701c)) * update max size of metrics on an entity to 24 ([#1329](#1329)) ([a520118](a520118)) * update subsetSchema ([#1386](#1386)) ([b1be3e2](b1be3e2)) * **hub-common:** add CRUD functions for entity settings ([#1275](#1275)) ([8eabc30](8eabc30)) * **hub-common:** change allowedLocations type from geometry array to … ([#1302](#1302)) ([f42c459](f42c459)) * **hub-common:** corrected error messages for varying inputs on details pane ([#1301](#1301)) ([41fc5cd](41fc5cd)) * **hub-common:** delete the discussion entity settings before the discussion entity ([#1360](#1360)) ([0900a8c](0900a8c)) * **hub-common:** enables discussions settings pane for users with edi… ([#1368](#1368)) ([714b979](714b979)) * **hub-common:** fix catalog filter query ([#1308](#1308)) ([12780c1](12780c1)) * **hub-common:** fix reharvest site catalog response interface ([#1339](#1339)) ([f6767f4](f6767f4)) * **hub-common:** page schema missing _thumbnail; caused details pane to crash ([#1294](#1294)) ([6502c6b](6502c6b)) * **hub-common:** prompt no longer required ([#1337](#1337)) ([9376161](9376161)) * **hub-common:** use only capabilities key to update extract capability service definition ([#1347](#1347)) ([9f6e0f3](9f6e0f3)) * remove scope from uiSchema for stat card ([#1298](#1298)) ([e0ef2ee](e0ef2ee)) * update followers group creation strings ([#1344](#1344)) ([4523f20](4523f20)) * **hub-discussions:** use the platform isOrgAdmin function in discussions access check ([#1341](#1341)) ([f221383](f221383)) * template workspace strings ([#1271](#1271)) ([3fa208f](3fa208f)) * update privacy config schema ([#1276](#1276)) ([7a3bb3f](7a3bb3f)) * update recommended templates slightly in initiative template workspace ([#1280](#1280)) ([f7fd636](f7fd636)) * view edit isviewonly ([#1418](#1418)) ([904bd27](904bd27)) * **hub-discussions:** rename DiscussionSettings to Settings for types and functions that call the ap ([#1264](#1264)) ([d0b77b3](d0b77b3)) ### Features * add a partners case to well known item catalog ([#1517](#1517)) ([0ddf25f](0ddf25f)) * add license permissions ([#1493](#1493)) ([53d2bcb](53d2bcb)) * alter feature flag for scheduler on content settings ([#1526](#1526)) ([0bc522c](0bc522c)) * **hub-common:** add event entity ([#1457](#1457)) ([b76092e](b76092e)) * **hub-common:** add isHubHome prop ([#1518](#1518)) ([f0bbf49](f0bbf49)) * remove props from site and page draft whitelists ([#1516](#1516)) ([3b31602](3b31602)) * **hub-common:** add attendees settings pane ([#1475](#1475)) ([0c49423](0c49423)) * **hub-common:** add facade methods related to entity sharing and ac… ([#1467](#1467)) ([7cfc46b](7cfc46b)) * **hub-common:** add fetchItemJobRecords function ([#1454](#1454)) ([082b847](082b847)) * **hub-common:** add function getRegistrations and fix type for page… ([#1468](#1468)) ([33599d3](33599d3)) * **hub-common:** add get s123 edit url util ([#1440](#1440)) ([f7d0dca](f7d0dca)) * **hub-common:** add new utils for a unified download flow ([#1482](#1482)) ([7f45d61](7f45d61)) * **hub-common:** add newsletters types and functions ([#1436](#1436)) ([35ff6f7](35ff6f7)) * **hub-common:** add permission to capture download errors ([#1458](#1458)) ([f132be4](f132be4)) * **hub-common:** add s123 url to context ([#1439](#1439)) ([be5f99e](be5f99e)) * **hub-common:** add support for searching for Events3 events from h… ([#1476](#1476)) ([4afe9a4](4afe9a4)) * **hub-common:** add timezone picker ([#1512](#1512)) ([eb10b4c](eb10b4c)) * **hub-common:** add token to schedule api endpoints ([#1502](#1502)) ([3206757](3206757)) * **hub-common:** create feedback entity ([#1414](#1414)) ([4a5e61e](4a5e61e)) * **hub-common:** introduces types and function modifications for discussion post search ([#1425](#1425)) ([b0080ff](b0080ff)) * **hub-common:** removes hub:feature:gallery:map permission policy ([#1500](#1500)) ([3c089e1](3c089e1)) * **hub-common:** show disabled scheduler setting with advisory notice for private items ([#1510](#1510)) ([6d856aa](6d856aa)) * 9161 follow card schema update ([#1406](#1406)) ([6b71911](6b71911)) * 9273 new follow entity and related functionalities ([#1438](#1438)) ([f5de4f2](f5de4f2)) * add canEditAccess permission to all entities ([#1445](#1445)) ([d129c15](d129c15)) * add deepDeletePropByValue and deepEqual util functions ([#1401](#1401)) ([9671261](9671261)) * add helper text to image ([#1488](#1488)) ([58f67ec](58f67ec)) * add orgId to IHubGroup ([#1434](#1434)) ([66c574d](66c574d)) * add owner permission ([#1473](#1473)) ([d539c92](d539c92)) * add permission to manage on umbrella ([#1403](#1403)) ([d438766](d438766)) * add projectAndInitiative as a new collection ([#1511](#1511)) ([fcf48e2](fcf48e2)) * add system permission for keyboard shortcuts ([#1408](#1408)) ([7d66793](7d66793)) * added permission for download errors ([#1465](#1465)) ([63351c5](63351c5)) * association group creation form and permission ([#1413](#1413)) ([64d01b4](64d01b4)) * context has user history ([#1411](#1411)) ([1c350cd](1c350cd)) * date option ([#1392](#1392)) ([ad8ba53](ad8ba53)) * enhance associations logic to handle forming associations ([#1395](#1395)) ([6eb7e5f](6eb7e5f)) * enrich initiatives with correct links ([#1460](#1460)) ([488818c](488818c)) * follow card permission and editor support ([#1394](#1394)) ([23feb30](23feb30)) * handle association group settings ([#1435](#1435)) ([6685e5e](6685e5e)) * implement assertion conditions ([#1424](#1424)) ([bfaeb5a](bfaeb5a)) * initiative workspace gated to alpha, but open to prod ([#1481](#1481)) ([46c4f09](46c4f09)) * loosen hub:feature:user:preferences permission ([#1470](#1470)) ([03fad00](03fad00)) * new schemas for creating view/edit groups ([#1400](#1400)) ([bdb63c8](bdb63c8)) * org thumbnail ([#1427](#1427)) ([2d61161](2d61161)) * post with enrichments ([#1447](#1447)) ([0a637c0](0a637c0)) * remove default groups ([#1483](#1483)) ([61a48f4](61a48f4)) * scaffold initiative metrics ([#1429](#1429)) ([891f80a](891f80a)) * scheduler added to content uischema ([#1471](#1471)) ([217be81](217be81)) * scheduler force update ([#1494](#1494)) ([5a8c47b](5a8c47b)) * types for entity views ([#1477](#1477)) ([89c6365](89c6365)) * **hub-common:** add events 3.0 functions ([#1397](#1397)) ([846f579](846f579)) * **hub-common:** add types for event addresses ([#1417](#1417)) ([7fe4657](7fe4657)) * **hub-common:** consolidates entity location construction and depre… ([#1382](#1382)) ([d067225](d067225)) * **hub-common:** remove hostedDownloads beta setting from content schemas / entity calculations ([#1422](#1422)) ([28af54f](28af54f)) * **hub-common:** update events schema for onlineMeetings ([#1421](#1421)) ([c81255f](c81255f)) * **hub-common:** update events types ([#1426](#1426)) ([83beb44](83beb44)) * **hub-common:** update feedback util ([#1433](#1433)) ([f71a855](f71a855)) * 8182 initiative creation ([#1343](#1343)) ([ac7d48d](ac7d48d)) * add advancedEditRelative to template links hash ([#1273](#1273)) ([cd87479](cd87479)) * add context.OGCApiUrl ([#1326](#1326)) ([dc08e2f](dc08e2f)) * add correct fields for static and dynamic ([#1346](#1346)) ([d2bf4c1](d2bf4c1)) * add enrichement to refetch item with additional props ([#1345](#1345)) ([3d3ac62](3d3ac62)) * add featured metrics limit ([#1334](#1334)) ([a662714](a662714)) * add generic action link interfaces/types ([#1328](#1328)) ([1441d28](1441d28)) * add logic/schema to allow follower group creation ([#1333](#1333)) ([9515f8c](9515f8c)) * add metric display config to hub.js ([#1290](#1290)) ([bef629c](bef629c)) * add metrics schema and uiSchema to projects ([#1296](#1296)) ([156e6f5](156e6f5)) * add new deepFilter util ([#1303](#1303)) ([c556b3c](c556b3c)) * add new processActionLinks util ([#1331](#1331)) ([166f598](166f598)) * add notices to IUserHubSettings ([#1351](#1351)) ([28e15b0](28e15b0)) * add permission for privacy; refactor workspace permissions ([#1291](#1291)) ([b9639e7](b9639e7)) * add recommendedTemplates to schema/uiSchema for initiative template workspace ([#1258](#1258)) ([339d1e6](339d1e6)) * add refreshUser method to context ([#1330](#1330)) ([a970ff8](a970ff8)) * add status to hub initiative ([#1319](#1319)) ([57662a7](57662a7)) * add structure for getting card editor schemas ([#1277](#1277)) ([6b82f03](6b82f03)) * add type for static metric value ([#1371](#1371)) ([af404bf](af404bf)) * add/update associations business logic ([#1370](#1370)) ([75abd91](75abd91)) * allow metrics visibility ([#1322](#1322)) ([366e369](366e369)) * attempt to force release ([5cf9381](5cf9381)) * description fields to rich text ([#1366](#1366)) ([1dec16f](1dec16f)) * expose portal limits on context ([#1385](#1385)) ([28b693d](28b693d)) * implement hub user settings and integrate with context ([#1305](#1305)) ([47de708](47de708)) * initiative/project description fields are rich text ([#1355](#1355)) ([02bb6bf](02bb6bf)) * polishing details pane for site workspace ([#1270](#1270)) ([e1eee40](e1eee40)) * release project metrics ([#1383](#1383)) ([f2c9a55](f2c9a55)) * remove temp discussions gating permission ([#1405](#1405)) ([fd280e7](fd280e7)) * **hub-common:** adds character limit to prompt field ([#1375](#1375)) ([e6503cd](e6503cd)) * **hub-common:** adds geometry to search results and new permission policy ([#1348](#1348)) ([3c082d5](3c082d5)) * **hub-common:** adds IHubLocation to IHubSearchResult ([#1376](#1376)) ([122d285](122d285)) * **hub-common:** adds temporary gated permissions for creating new d… ([#1342](#1342)) ([2fc2d78](2fc2d78)) * **hub-common:** enable content settings for admins and add content delete permission ([#1372](#1372)) ([00ecba2](00ecba2)) * search result has rawResult prop ([#1336](#1336)) ([c8a41f4](c8a41f4)) * update projects schema ([#1354](#1354)) ([8904324](8904324)) * **hub-common:** add "reharvestSiteCatalog" util ([#1279](#1279)) ([6bdda94](6bdda94)) * **hub-common:** add default predicate for portal search ([#1315](#1315)) ([6a42e63](6a42e63)) * **hub-common:** add function to get feed configuration ([#1261](#1261)) ([79fcc47](79fcc47)) * **hub-common:** add section heading for template ui schemas ([#1274](#1274)) ([cdabf33](cdabf33)) * **hub-common:** add support for discussion settings for entities ([#1284](#1284)) ([951c455](951c455)) * **hub-common:** added rows to text area input ([#1287](#1287)) ([aab4eda](aab4eda)) * **hub-common:** allow boolean predicates for OGC searches, openData flag for OGC aggs requests ([#1292](#1292)) ([b15ea86](b15ea86)) * **hub-common:** allow workspaces to route to specific panes ([#1332](#1332)) ([d126dee](d126dee)) * **hub-common:** hubSearchItems filters aggregations requests by the provided query ([#1327](#1327)) ([df53fb9](df53fb9)) * **hub-common:** persist location onto discussion allowedLocations settings ([#1316](#1316)) ([87d17a3](87d17a3)) * **hub-common:** rows added to text area inputs ([#1286](#1286)) ([e037beb](e037beb)) * **hub-common:** sets discussion board isDiscussable true by default ([#1309](#1309)) ([98f3d28](98f3d28)) * **hub-common:** unify thumbnail ui schema for item-backed entities and add default thumbnail notice ([#1267](#1267)) ([30bc262](30bc262)) * **hub-common:** updates DiscussionUiSchemaEdit schema layout and de… ([#1325](#1325)) ([1336de1](1336de1)) * **hub-common:** upgradeCatalogSchema handles "orgId" field in legacy catalogs ([#1299](#1299)) ([8e85c47](8e85c47)) * **hub-discussions:** true isOrgAdmin check if org_admin via platfor… ([#1338](#1338)) ([520a5d0](520a5d0)) * max length error messages ([#1295](#1295)) ([4d7705e](4d7705e)) * support for Site and Hub user app resources ([#1260](#1260)) ([4a314e1](4a314e1)) * telemetry config ([#1272](#1272)) ([7a0a40c](7a0a40c)) * trigger release for rows added to text area inputs ([#1285](#1285)) ([dab4400](dab4400)) * update project schema/metricsUiSchema ([#1323](#1323)) ([ac3a6fa](ac3a6fa)) * **hub-discussions:** added paging params to IFetchPost ([#1281](#1281)) ([63a405a](63a405a)) ### Reverts * corrected package-lock by running npm i ([#1504](#1504)) ([bfe76f1](bfe76f1)) * Revert "chore: update github token for release (#1349)" (#1357) ([dd201e7](dd201e7)), closes [#1349](#1349) [#1357](#1357) ### BREAKING CHANGES * **hub-discussions:** function isOrgAdmin returns true if the user is an org_admin by an assigned roleId * docs(hub-discussions): update function description for isOrgAdmin affects: @esri/hub-discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10490
Description
Recommended templates in the initiative template workspace (Details pane) should link to the template view rather than the template workspace.
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.