fix(t9n): fix error caused by disconnecting components during the setting of initial message overrides #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting of initial message overrides
jcfranco
added
the
skip visual snapshots
jcfranco
changed the title
jcfranco
deleted the
jcfranco/9240-fix-error-when-messages-are-updated-on-disconnected-component
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9240
Summary
This updates the
t9nmodule to use a noop function (instead of undefined) for the injected watcher callback when disconnected. This change addresses an issue where a component invokes watchers during disconnection.