Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): fix checkbox hit area placement in RTL #9367

Merged
merged 1 commit into from
May 20, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: #8841

Summary

Updates styles to position hit area horizontally according to page direction.

@jcfranco jcfranco requested a review from a team as a code owner May 18, 2024 04:14
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 18, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 18, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@jcfranco jcfranco merged commit 142ef18 into main May 20, 2024
11 checks passed
@jcfranco jcfranco deleted the jcfranco/8841-fix-checkbox-hit-area-in-rtl branch May 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants