refactor(dom): consolidate transition/animation waiting utils #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
jcfranco
added
the
pr ready for visual snapshots
jcfranco
requested review from
benelan,
driskull,
geospatialem and
a team
as code owners
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
driskull
requested changes
May 28, 2024
| ) => void; | ||
|
|
||
| beforeEach(() => { | ||
| // we clobber Stencil's custom Mock document implementation |
|
|
||
| element.style.transition = testTransition; | ||
|
|
||
| // need to mock due to JSDOM issue with getComputedStyle - https://github.com/jsdom/jsdom/issues/3090 |
| * @param targetEl The element to watch for the transition to complete. | ||
| * @param transitionProp The name of the transition to watch for completion. | ||
| */ | ||
| export async function whenTransitionDone(targetEl: HTMLElement, transitionProp: string): Promise<void> { |
There was a problem hiding this comment.
Can't we just use onTransitionEnd on a VNode in most cases? Should we specify that?
There was a problem hiding this comment.
I think we can tweak the name and doc to better explain its usage.
github-actions
bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Stems from #9325 (comment).
Consolidates transition/animation waiting logic and adds
whenTransitionDoneto DOM utils to complementwhenAnimationDone.