Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List preplanned map areas #723

Merged
merged 48 commits into from
May 22, 2024
Merged

List preplanned map areas #723

merged 48 commits into from
May 22, 2024

Conversation

des12437
Copy link
Contributor

Related to swift/5309

@des12437 des12437 requested a review from yo1995 May 10, 2024 19:21
@des12437 des12437 self-assigned this May 10, 2024
yo1995
yo1995 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial cosmetic changes.

Examples/Examples/OfflineMapAreasExampleView.swift Outdated Show resolved Hide resolved
Examples/Examples.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/Utilities/LoadableImageView.swift Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/Utilities/LoadableImageView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
@des12437 des12437 requested a review from yo1995 May 10, 2024 23:32
yo1995
yo1995 reviewed May 13, 2024
View reviewed changes
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedMapModel.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/Utilities/LoadableImageView.swift Show resolved Hide resolved
@des12437 des12437 requested a review from yo1995 May 13, 2024 21:49
yo1995
yo1995 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that is worth considering is to use the app tintColor for all interact-able controls, such as the Image symbols. That can be done in the next phase of this user story.

Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
@des12437 des12437 requested a review from yo1995 May 15, 2024 20:03
yo1995
yo1995 reviewed May 16, 2024
View reviewed changes
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/OfflineMapAreasView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedMapModel.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
Sources/ArcGISToolkit/Components/OfflineMapAreasView/PreplannedListItemView.swift Outdated Show resolved Hide resolved
@des12437 des12437 requested review from rolson and yo1995 May 21, 2024 00:11
@rolson rolson mentioned this pull request May 21, 2024
Merged
rolson and others added 13 commits May 21, 2024 16:47
@rolson
handle illegal state error
5e6a940
@rolson
move can download
6b20002
@rolson
create protocol
888e980
@rolson
remove unused property
b2fbb64
@rolson @des12437
Update Sources/ArcGISToolkit/Components/OfflineMapAreasView/Preplanne…
d99ccba 
…dListItemView.swift

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@rolson
Merge pull request #734 from Esri/ryan/list-preplanned-map-areas
9cb2a4c 
pr feedback: list-preplanned-map-areas
@rolson
Merge branch 'List-Preplanned-Map-Areas' into ryan/list-preplanned-ma…
2bfaf00 
…p-areas2
@rolson
Merge branch 'ryan/list-preplanned-map-areas2' into ryan/preplanned-mock
9d0070f
@rolson @des12437
Apply suggestions from code review
63ee53a 
Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@rolson
fix error
e236a19
@rolson
fix error
da9c5cc
@rolson
Merge pull request #735 from Esri/ryan/list-preplanned-map-areas2
4c60fee 
List Preplanned Map Areas: Simplify status, move more logic into model
@rolson
code cleanup
25d9dcb
@des12437 des12437 requested a review from yo1995 May 22, 2024 18:33
@rolson
Merge pull request #740 from Esri/ryan/preplanned-mock
c679b6e 
Create protocol for allowing us to mock for testing and potentially previews
@des12437 des12437 requested a review from yo1995 May 22, 2024 21:00
@des12437 des12437 merged commit 640276f into OfflineMapAreasView May 22, 2024
@des12437 des12437 deleted the List-Preplanned-Map-Areas branch May 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolson rolson rolson approved these changes

@yo1995 yo1995 yo1995 approved these changes

Assignees

@des12437 des12437

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@des12437 @rolson @yo1995