Forms Consume new attachments api
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename-attachments
sorenoid
reviewed
May 22, 2024
| // scroll to the new attachment after a delay to allow the recomposition to complete | ||
| delay(100) | ||
| lazyListState.scrollToItem(attachments.count()) | ||
| formElement.addAttachment(name, contentType, data).onSuccess { formAttachment -> |
There was a problem hiding this comment.
why is the addition to the state list done here and not in response to the added change event like rename and delete?
There was a problem hiding this comment.
@sorenoid fixed!
sorenoid
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
attachmentChangedevent to handle deletion and renaming of attachments.AttachmentElementState.attachmentsfrom aMapto aList. This is because theMapdoes not preserve insertion order without an additional overhead. Using a list preserves the insertion order but increases the time complexity for deletion and rename to O(n).AttachmentElementState.Saverdoes to store load statuses of itsFormAttachmentState. Instead, this can be inferred by looking at theFormAttachmentobjects when building the state list.FormAttachmentStatespecifies a smaller size for the thumbnail to save on memory, which increased the UI responsiveness quite a bit.