Popup attachment element
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Add missing version for artifact not covered by compose bom (androidx-activity:activity-compose)
pull compose bom into androidTest and test Implementations when needed. Add missing version for artifact not covered by compose bom (androidx-activity:activity-compose).
…experimental coroutine API
…nto sor10874/sprintx/fix-warnings
This reverts commit c888b6b.
Co-authored-by: Erick Lopez Solis <erick_solis@esri.com>
…sor10874/state-collection
… into sor10874/update-expandable-card
added 6 commits
May 15, 2024 09:40
puneet-pdx
approved these changes
May 17, 2024
There was a problem hiding this comment.
@sorenoid LGTM 👍🏽 . Could use some cleaning up of unnecessary newlines which I pointed out.
.../java/com/arcgismaps/toolkit/popup/internal/element/attachment/AttachmentsElementDefaults.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/arcgismaps/toolkit/popup/internal/element/attachment/AttachmentsElementState.kt
Show resolved
Hide resolved
...ain/java/com/arcgismaps/toolkit/popup/internal/element/attachment/AttachmentsPopupElement.kt
Show resolved
Hide resolved
eri9000
requested changes
May 20, 2024
...ain/java/com/arcgismaps/toolkit/popup/internal/element/attachment/AttachmentsPopupElement.kt
Outdated
Show resolved
Hide resolved
...pup/src/main/java/com/arcgismaps/toolkit/popup/internal/element/attachment/AttachmentTile.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support to display AttachmentsPopupElement in a Popup with