Fix for the rotation bug #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
puneet-pdx
commented
May 15, 2024
puneet-pdx
commented
- Add logic to only initialize the Callout when the MapView is done with initial draw
- Move the onViewPointChanged listener from MapView to Callout to prevent unnecessary MapView recompositions.
- Move invocation of the Content lambda after all the MapViewEventHandlers and ViewPointHandlers are set
sorenoid
approved these changes
May 16, 2024
| { | ||
| this.content() | ||
| // Convert the given location to a screen coordinate | ||
| var calloutScreenCoordinate: ScreenCoordinate by remember { |
There was a problem hiding this comment.
possibly this could key on location then it doesn't need to be assigned in the LaunchedEffect.
Suggested change
| var calloutScreenCoordinate: ScreenCoordinate by remember { | |
| var calloutScreenCoordinate: ScreenCoordinate by remember(location) { |
There was a problem hiding this comment.
I think this is not the key but the initial value for the calloutScreenCoordinate. we are using the changes to the state of calloutScreenCoordinate to trigger recomposition.
…nRotation # Conflicts: # toolkit/geoview-compose/src/main/java/com/arcgismaps/toolkit/geoviewcompose/Callout.kt
shubham7109
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.