Popup: Adds FieldsPopupElement composable
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Add missing version for artifact not covered by compose bom (androidx-activity:activity-compose)
pull compose bom into androidTest and test Implementations when needed. Add missing version for artifact not covered by compose bom (androidx-activity:activity-compose).
…experimental coroutine API
…nto sor10874/sprintx/fix-warnings
This reverts commit c888b6b.
Co-authored-by: Erick Lopez Solis <erick_solis@esri.com>
…sor10874/state-collection
… into Erick/FieldsPopupElement
… into Erick/FieldsPopupElement
…ck/FieldsPopupElement # Conflicts: # toolkit/popup/src/main/java/com/arcgismaps/toolkit/popup/Popup.kt
sorenoid
approved these changes
May 20, 2024
…upElement # Conflicts: # toolkit/popup/src/main/java/com/arcgismaps/toolkit/popup/Popup.kt
shubham7109
reviewed
May 21, 2024
| ExpandableCard( | ||
| title = state.title, | ||
| description = state.description, | ||
| elementCount = state.fieldsToFormattedValues.size, |
There was a problem hiding this comment.
This looks to be using elementCount which has been removed from ExpandableCard in this PR. I was planning on reviewing it when I reached this compilation error.
puneet-pdx
reviewed
May 22, 2024
There was a problem hiding this comment.
@eri9000 this branch also has conflicts, can you please resolve them.
# Conflicts: # toolkit/popup/src/main/java/com/arcgismaps/toolkit/popup/Popup.kt
puneet-pdx
approved these changes
May 22, 2024
There was a problem hiding this comment.
@eri9000 changes look good, but I do see a flicker when scrolling the fields popup element and it seems the list resets and I have to scroll twice as much to get back to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FieldsPopupElement composable to display FieldsPopupElements in a Popup.