small template changes #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneet-pdx
reviewed
May 1, 2024
| composableFunctionName="${name^}" | ||
| appDirName="${composableFunctionName}" | ||
| if [[ ! "${appDirName}" =~ .+App$ ]] ; then | ||
| appDirName="${composableFunctionName}App" | ||
| fi | ||
|
|
||
| echo copying and converting app files, estimated time 1 minute. | ||
| echo copying and converting app files, compnentName $componentName composableFunctionName $composableFunctionName time 1 minute. |
There was a problem hiding this comment.
Suggested change
| echo copying and converting app files, compnentName $componentName composableFunctionName $composableFunctionName time 1 minute. | |
| echo copying and converting app files, componentName $componentName composableFunctionName $composableFunctionName time 1 minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add the binary compatibility validator plugin by default to new components. this PR does that. it is already included in the project level gradle.
Also the new microapp starter script had a small issue where the
componentNameincluded the suffixapp. It did not have this suffix when the value was derived from the new component, but now that it is a standalone script it crept in.